Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qualified name get bug #669

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

wiyr
Copy link
Contributor

@wiyr wiyr commented Apr 7, 2022

Summary

resolves #656

Test Plan

python -m unittest libcst.metadata.tests.test_scope_provider.ScopeProviderTest.test_get_qualified_names_for_the_same_prefix

Verified

This commit was signed with the committer’s verified signature.
gsmet Guillaume Smet
@facebook-github-bot
Copy link

Hi @wiyr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@stroxler
Copy link
Contributor

stroxler commented Apr 7, 2022

Thanks for the fix @wiyr!

This looks good to me, but it would be clearer if it shipped with a new unit test that would have failed on the old code. Do you have time to add that?

@stroxler
Copy link
Contributor

stroxler commented Apr 7, 2022

FYI the CI failures are not related - they are due to a click/black version mismatch and I'm working on a fix

@wiyr wiyr force-pushed the fix_qualified_bug branch from ca84114 to 4bfc385 Compare April 8, 2022 03:02
@wiyr
Copy link
Contributor Author

wiyr commented Apr 8, 2022

added one simple unittest

Copy link
Contributor

@stroxler stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QualifiedNameProvider return multi nodes strangely
3 participants